Improved performance and less shadowing

This commit is contained in:
Eduard Urbach 2020-02-12 13:30:35 +09:00
parent 1d9744ef6a
commit 2a20b281c7
Signed by: akyoto
GPG Key ID: C874F672B1AF20C0

View File

@ -13,14 +13,16 @@ import (
func Get(ctx aero.Context) error { func Get(ctx aero.Context) error {
id := ctx.Get("id") id := ctx.Get("id")
track, err := arn.GetSoundTrack(id) track, err := arn.GetSoundTrack(id)
user := arn.GetUserFromContext(ctx)
if err != nil { if err != nil {
return ctx.Error(http.StatusNotFound, "Track not found", err) return ctx.Error(http.StatusNotFound, "Track not found", err)
} }
user := arn.GetUserFromContext(ctx)
animes := track.Anime()
relatedTracks := arn.FilterSoundTracks(func(t *arn.SoundTrack) bool { relatedTracks := arn.FilterSoundTracks(func(t *arn.SoundTrack) bool {
return !t.IsDraft && len(t.Media) > 0 && t.ID != track.ID && isRelated(track.Anime(), t) return !t.IsDraft && len(t.Media) > 0 && t.ID != track.ID && isRelated(animes, t)
}) })
customCtx := ctx.(*middleware.OpenGraphContext) customCtx := ctx.(*middleware.OpenGraphContext)
@ -28,8 +30,8 @@ func Get(ctx aero.Context) error {
return ctx.HTML(components.SoundTrackPage(track, relatedTracks, user)) return ctx.HTML(components.SoundTrackPage(track, relatedTracks, user))
} }
func isRelated(anime []*arn.Anime, track *arn.SoundTrack) bool { func isRelated(animes []*arn.Anime, track *arn.SoundTrack) bool {
for _, anime := range anime { for _, anime := range animes {
if arn.Contains(track.Tags, "anime:"+anime.ID) { if arn.Contains(track.Tags, "anime:"+anime.ID) {
return true return true
} }