From 28aef487c55619e2c0183bb553d3de7b001812fc Mon Sep 17 00:00:00 2001 From: Eduard Urbach Date: Wed, 8 May 2019 17:16:47 +0900 Subject: [PATCH] Enabled a few linters --- .drone.yml | 4 ++-- go.mod | 6 ++---- go.sum | 16 ++++++++-------- pages/editor/mal.go | 1 + pages/explore/explore.go | 2 +- 5 files changed, 14 insertions(+), 15 deletions(-) diff --git a/.drone.yml b/.drone.yml index bfa9f710..c9bc362b 100644 --- a/.drone.yml +++ b/.drone.yml @@ -13,6 +13,8 @@ steps: - tsc - pack - go build -v + - curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.16.0 + - golangci-lint run --disable-all --enable deadcode --enable misspell --enable prealloc - go test -v -coverprofile=coverage.txt . # - go mod download # - make tools @@ -22,8 +24,6 @@ steps: # - tsc # - pack # - make server - # - curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.16.0 - # - golangci-lint run --enable dupl # - make bots jobs patches # - git clone --depth=1 https://github.com/animenotifier/database ~/.aero/db/arn # - go test -v -coverprofile=coverage.txt ./... diff --git a/go.mod b/go.mod index 6c00a550..b2b56ee4 100644 --- a/go.mod +++ b/go.mod @@ -8,21 +8,19 @@ require ( github.com/StackExchange/wmi v0.0.0-20181212234831-e0a55b97c705 // indirect github.com/aerogo/aero v1.1.7 github.com/aerogo/api v0.1.6 - github.com/aerogo/cluster v0.1.6 // indirect github.com/aerogo/crawler v0.2.1 github.com/aerogo/http v1.0.3 github.com/aerogo/layout v0.1.5 github.com/aerogo/log v0.2.4 github.com/aerogo/markdown v0.1.5 - github.com/aerogo/mirror v0.1.4 // indirect - github.com/aerogo/nano v0.1.7 + github.com/aerogo/nano v0.2.0 github.com/aerogo/pack v0.4.0 github.com/aerogo/run v0.1.4 github.com/aerogo/session-store-nano v0.1.3 github.com/aerogo/sitemap v0.1.1 github.com/akyoto/color v1.8.3 github.com/animenotifier/anilist v0.2.2 - github.com/animenotifier/arn v1.1.16 + github.com/animenotifier/arn v1.1.17 github.com/animenotifier/kitsu v0.2.2 github.com/animenotifier/mal v0.2.2 github.com/animenotifier/shoboi v0.2.2 diff --git a/go.sum b/go.sum index 0b4fcecc..aa66c26e 100644 --- a/go.sum +++ b/go.sum @@ -58,12 +58,12 @@ github.com/aerogo/markdown v0.1.5 h1:rzgRDgI7pL/c9Z+wu2Q9rVqr+a8gyB8tmGGl3Ce8Xxk github.com/aerogo/markdown v0.1.5/go.mod h1:e/ZnjP3vdg1yB5XKK89r/lAAqNRW6aqaD1dSZaTW2F4= github.com/aerogo/mirror v0.1.3 h1:813FatCdChOvgWen2EcZNnRfxAeo9zmu/TgDNOnsDx0= github.com/aerogo/mirror v0.1.3/go.mod h1:Un87Jq8RIRrb2bU1CxVToJjVZgSMLUQXxVLCXln4rUU= -github.com/aerogo/mirror v0.1.4 h1:zCv8UV/C6sOdOyIuVMejcATocLVbL3zJeUwMtib4ex8= -github.com/aerogo/mirror v0.1.4/go.mod h1:Un87Jq8RIRrb2bU1CxVToJjVZgSMLUQXxVLCXln4rUU= +github.com/aerogo/mirror v0.1.5 h1:i4pnLjie0ZG6AlYkBiXT/EmKCrsjo2/kjBMUVT86ch4= +github.com/aerogo/mirror v0.1.5/go.mod h1:Un87Jq8RIRrb2bU1CxVToJjVZgSMLUQXxVLCXln4rUU= github.com/aerogo/nano v0.1.6 h1:FtWokAa8SZcm5kHlW10OkaUnqlFE4eQGvEfkiSBVsek= github.com/aerogo/nano v0.1.6/go.mod h1:NxWlxJWtm2s4gB4CcJGy5Lsofz1ZgvEGtv5dEQVNa94= -github.com/aerogo/nano v0.1.7 h1:usInw70W0/OPyUVML2qXi2kLr3K1dMzIyyG3iz5Ccak= -github.com/aerogo/nano v0.1.7/go.mod h1:tbR/fVGJb2rRFdPp9+D0INJgkhzQ+9XKefLTI11xNFU= +github.com/aerogo/nano v0.2.0 h1:qcCdCsAtN1Qpw8DhZQXiLVJYsjmpQMmZ7TPFD2GkwVw= +github.com/aerogo/nano v0.2.0/go.mod h1:tbR/fVGJb2rRFdPp9+D0INJgkhzQ+9XKefLTI11xNFU= github.com/aerogo/pack v0.4.0 h1:H/tcKD8RzagypjXUabdRWzEO/t98lYHhTOPk5IVsIyo= github.com/aerogo/pack v0.4.0/go.mod h1:jVXnvmCKOasbPzmfLP5yU9zEerNd+RKA9ekomOthYZQ= github.com/aerogo/packet v0.1.3 h1:8SrI9KLYQiGAcDElvWeXAKqnydSIBDw0H5+y4A1fZuM= @@ -110,8 +110,8 @@ github.com/andybalholm/cascadia v1.0.0 h1:hOCXnnZ5A+3eVDX8pvgl4kofXv2ELss0bKcqRy github.com/andybalholm/cascadia v1.0.0/go.mod h1:GsXiBklL0woXo1j/WYWtSYYC4ouU9PqHO0sqidkEA4Y= github.com/animenotifier/anilist v0.2.2 h1:zLL9KabDJx2a+yNT+b13ORWvKlLTsFL67hBKLXyImSI= github.com/animenotifier/anilist v0.2.2/go.mod h1:orL7qr/k64K2YEUYESjr1rhp6+0BXdJmiANxG3OV30U= -github.com/animenotifier/arn v1.1.16 h1:uVkDNnqJyZT9OAep3ddPvqQY9B4RsX6mOH2auekdQDc= -github.com/animenotifier/arn v1.1.16/go.mod h1:c4v232l3UZOi9Yw4DumISzlFME3kApZNDBnqb4a0vtg= +github.com/animenotifier/arn v1.1.17 h1:a3z9U3Vm/Ykj0XsFH0D59AY4MaeVloW3jVsnFUN4Fn4= +github.com/animenotifier/arn v1.1.17/go.mod h1:6plG9EWGa8Arwgg0/6befqEjjhZlj5AT9VTqyScgMMs= github.com/animenotifier/ffxiv v0.2.0 h1:I6LgRtV1MOH/CYxyGlU3hQzLOuof2hMhLvQivRDY1JE= github.com/animenotifier/ffxiv v0.2.0/go.mod h1:95gF9YZXwmFiXqXTeIQ6VP5qfsErIguQb1q6w2f6Etk= github.com/animenotifier/japanese v0.2.2 h1:3+jJvwlA6K7ijFsVPA/coQlwQE3ca6PkNpNMBhYi9tc= @@ -299,8 +299,8 @@ golang.org/x/sys v0.0.0-20190429190828-d89cdac9e872 h1:cGjJzUd8RgBw428LXP65YXni0 golang.org/x/sys v0.0.0-20190429190828-d89cdac9e872/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190502175342-a43fa875dd82 h1:vsphBvatvfbhlb4PO1BYSr9dzugGxJ/SQHoNufZJq1w= golang.org/x/sys v0.0.0-20190502175342-a43fa875dd82/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= -golang.org/x/sys v0.0.0-20190507053917-2953c62de483 h1:0pONs62zZ8ED8kUnSCsv4RWjmwM6ideAalXGTybpo2s= -golang.org/x/sys v0.0.0-20190507053917-2953c62de483/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190507160741-ecd444e8653b h1:ag/x1USPSsqHud38I9BAC88qdNLDHHtQ4mlgQIZPPNA= +golang.org/x/sys v0.0.0-20190507160741-ecd444e8653b/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0 h1:g61tztE5qeGQ89tm6NTjjM9VPIm088od1l6aSorWRWg= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/text v0.3.1-0.20180807135948-17ff2d5776d2 h1:z99zHgr7hKfrUcX/KsoJk5FJfjTceCKIp96+biqP4To= diff --git a/pages/editor/mal.go b/pages/editor/mal.go index e0844b69..b0a606ea 100644 --- a/pages/editor/mal.go +++ b/pages/editor/mal.go @@ -122,6 +122,7 @@ func compare(animes []*arn.Anime) []*utils.MALComparison { // diff returns all the differences between an anime and its MAL counterpart. func diff(anime *arn.Anime, malAnime *mal.Anime) []animediff.Difference { + // nolint (prealloc linter would complain, but this is best left as nil by default) var differences []animediff.Difference // We'll use the following diffs diff --git a/pages/explore/explore.go b/pages/explore/explore.go index f8a943a8..00653540 100644 --- a/pages/explore/explore.go +++ b/pages/explore/explore.go @@ -57,7 +57,7 @@ func Filter(ctx *aero.Context) string { } func filterAnime(year, season, status, typ string) []*arn.Anime { - var results []*arn.Anime + results := make([]*arn.Anime, 0, 1024) for anime := range arn.StreamAnime() { if year != "any" {