web/notify.moe
Code Issues Pull Requests Activity

Don't reuse diff container

Browse Source
This commit is contained in:
Eduard Urbach 2018-04-07 12:34:41 +02:00
parent a941af77f2
commit 27264d691a
1 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
scripts/Diff.ts
View File

@ -3,22 +3,15 @@ import { MutationQueue } from "./MutationQueue"
export default class Diff { export default class Diff {
static persistentClasses = new Set<string>() static persistentClasses = new Set<string>()
static persistentAttributes = new Set<string>() static persistentAttributes = new Set<string>()
// Reuse container for diffs to avoid memory allocation
static container: HTMLElement
static rootContainer: HTMLElement
static mutations: MutationQueue = new MutationQueue() static mutations: MutationQueue = new MutationQueue()
// innerHTML will diff the element with the given HTML string and apply DOM mutations. // innerHTML will diff the element with the given HTML string and apply DOM mutations.
static innerHTML(aRoot: HTMLElement, html: string): Promise<void> { static innerHTML(aRoot: HTMLElement, html: string): Promise<void> {
if(!Diff.container) { let container = document.createElement("main")
Diff.container = document.createElement("main") container.innerHTML = html
}
Diff.container.innerHTML = html
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
Diff.childNodes(aRoot, Diff.container) Diff.childNodes(aRoot, container)
this.mutations.wait(resolve) this.mutations.wait(resolve)
}) })
} }
@ -26,13 +19,10 @@ export default class Diff {
// root will diff the document root element with the given HTML string and apply DOM mutations. // root will diff the document root element with the given HTML string and apply DOM mutations.
static root(aRoot: HTMLElement, html: string) { static root(aRoot: HTMLElement, html: string) {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
if(!Diff.rootContainer) { let rootContainer = document.createElement("html")
Diff.rootContainer = document.createElement("html") rootContainer.innerHTML = html.replace("<!DOCTYPE html>", "")
}
Diff.rootContainer.innerHTML = html.replace("<!DOCTYPE html>", "") Diff.childNodes(aRoot.getElementsByTagName("body")[0], rootContainer.getElementsByTagName("body")[0])
Diff.childNodes(aRoot.getElementsByTagName("body")[0], Diff.rootContainer.getElementsByTagName("body")[0])
this.mutations.wait(resolve) this.mutations.wait(resolve)
}) })
} }