Improved type system checks

src/core/CompileCall.go

@@ -14,7 +14,7 @@ import (
 // All call registers must hold the correct parameter values before the function invocation.
 // Registers that are in use must be saved if they are modified by the function.
 // After the function call, they must be restored in reverse order.
-func (f *Function) CompileCall(root *expression.Expression) (*Function, error) {
+func (f *Function) CompileCall(root *expression.Expression) ([]types.Type, error) {
 	var (
 		pkg      = f.Package
 		pkgNode  *expression.Expression
@@ -29,25 +29,12 @@ func (f *Function) CompileCall(root *expression.Expression) (*Function, error) {
 
 		switch name {
 		case "len":
-			return &Function{
-				Output: []*Output{
-					{
-						Type: types.Int,
-					},
-				},
-			}, f.CompileLen(root)
+			return _len.OutputTypes, f.CompileLen(root)
 		case "syscall":
 			return nil, f.CompileSyscall(root)
 		case "new":
 			typ, err := f.CompileNew(root)
-
-			return &Function{
-				Output: []*Output{
-					{
-						Type: typ,
-					},
-				},
-			}, err
+			return []types.Type{typ}, err
 		case "delete":
 			return nil, f.CompileDelete(root)
 		case "store":
@@ -112,29 +99,16 @@ func (f *Function) CompileCall(root *expression.Expression) (*Function, error) {
 		}
 
 		if !types.Is(typ, fn.Input[i].Type) {
-			if parameters[i].Token.Kind == token.Number && parameters[i].Token.Text(f.File.Bytes) == "0" {
+			_, expectsPointer := fn.Input[i].Type.(*types.Pointer)
+
+			if expectsPointer && parameters[i].Token.Kind == token.Number && parameters[i].Token.Text(f.File.Bytes) == "0" {
 				continue
 			}
 
-			encountered := ""
-			expected := ""
-
-			if typ != nil {
-				encountered = typ.Name()
-			}
-
-			if fn.Input[i].Type != nil {
-				expected = fn.Input[i].Type.Name()
-			}
-
-			return nil, errors.New(&errors.TypeMismatch{
-				Encountered:   encountered,
-				Expected:      expected,
-				ParameterName: fn.Input[i].Name,
-			}, f.File, parameters[i].Token.Position)
+			return nil, errors.New(&errors.TypeMismatch{Encountered: typ.Name(), Expected: fn.Input[i].Type.Name(), ParameterName: fn.Input[i].Name}, f.File, parameters[i].Token.Position)
 		}
 	}
 
 	f.CallSafe(fn, registers)
-	return fn, nil
+	return fn.OutputTypes, nil
 }